[TrafficManager] Real User Metrics (RUM) fixes#1920
[TrafficManager] Real User Metrics (RUM) fixes#1920lmazuel merged 17 commits intoAzure:currentfrom allencal:current
Conversation
…raffic Manager. [Traffic Manager] Adding new RealtimeUserMetrics preview feature to Traffic Manager.
…ure. [Traffic Manager] Adding new Realtime User Metrics (RUM) preview feature.
…ure. [Traffic Manager] Adding new Realtime User Metrics (RUM) preview feature.
…ure. [Traffic Manager] Adding new Realtime User Metrics (RUM) preview feature.
…ure. [Traffic Manager] Adding new Realtime User Metrics (RUM) preview feature.
…ure. [Traffic Manager] Adding new Realtime User Metrics (RUM) preview feature.
…ure. [Traffic Manager] Adding new Realtime User Metrics (RUM) preview feature.
…ure. [Traffic Manager] Adding new Realtime User Metrics (RUM) preview feature.
# Conflicts: # specification/trafficmanager/resource-manager/Microsoft.Network/2017-05-01/trafficmanager.json
This reverts commit b703b5e.
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: 💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡 File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
| "properties": { | ||
| "id": { | ||
| "type" : "string", | ||
| "description": "Fully qualified resource Id for the resource. Ex - /providers/Microsoft.Network/trafficManagerUserMetricsKeys/default" |
There was a problem hiding this comment.
It seems you removed "default" evrywhere else, is the description still accurate?
There was a problem hiding this comment.
You're right, I think I should change this here. The "/default" is still returned in this description, though it shouldn't be; the call with "/default" on the end fails. I'll remove it here, and also in the API operation.
| "$ref": "#/definitions/TrafficManagerUserMetricsKeyModel" | ||
| } | ||
| }, | ||
| "204": { |
There was a problem hiding this comment.
Does this mean that 204 is impossible, or you want now a 204 to raise an exception?
There was a problem hiding this comment.
The "Get" operation never returns a 204. If the subscription has no RUM key, it returns a 200 and the body returns a blank key ("key": "")
lmazuel
changed the title
…om resource ID and operation ID [TrafficManager] Real User Metrics (RUM) fixes II - remove default from resource ID and operation ID
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: 💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡 File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
lmazuel
left a comment
lmazuel
left a comment
There was a problem hiding this comment.
LGTM. Tell me if you sign-off or if you have more to add.
|
I do not have more to add. I'm not authorized to merge this pull request. What happens next? |
|
@allencal Next is I merge :) |
|
No modification for AutorestCI/azure-sdk-for-node |
4 participants
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger